On Thu, 10 Dec 2020 13:45:21 GMT, Jorn Vernee <[email protected]> wrote:
>> Nick Gasson has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments
>
> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 3104:
>
>> 3102: const
>> GrowableArray<VMReg>& output_registers) {
>> 3103: BufferBlob* _invoke_native_blob =
>> 3104: BufferBlob::create("nep_invoker_blob",
>> MethodHandles::adapter_code_size);
>
> That reminds me; this should _not_ use MethodHandles::adapter_code_size, but
> a separate constant, since the former is tailored specifically to method
> handle stubs (and is too large for this case). I still need to update the one
> for x86 as well (looks like I forgot to do that one before when I changed
> them for invoker/upcall handler). I think 1024 bytes should be more than
> enough, but would need to test it.
I've changed it to 1024 for AArch64, definitely large enough.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1711
