On Tue, 10 May 2022 20:30:09 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 21 commits: >> >> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2 >> - Remove unneeded ComputeMoveOrder >> - Remove comment about native calls in lcm.cpp >> - 8284072: foreign/StdLibTest.java randomly crashes on MacOS/AArch64 >> >> Reviewed-by: jvernee, mcimadamore >> - Update riscv and arm stubs >> - Remove spurious ProblemList change >> - Pass pointer to LogStream >> - Polish >> - Replace TraceNativeInvokers flag with unified logging >> - Fix other platforms, take 2 >> - ... and 11 more: >> https://git.openjdk.java.net/jdk/compare/3c88a2ef...43fd1b91 > > src/hotspot/share/prims/foreign_globals.cpp line 147: > >> 145: // based on ComputeMoveOrder from x86_64 shared runtime code. >> 146: // with some changes. >> 147: class ForeignCMO: public StackObj { > > Considering how seldom it is used, I don't see much value in abbreviating it. > Also, the comment is misleading: there's no such entity as `ComputeMoveOrder` > in the code. And `compute_move_order` is completely removed by this change. Good points, I think we can just rename this class to `ComputeMoveOrder` at this point. ------------- PR: https://git.openjdk.java.net/jdk/pull/7959