On Tue, 10 May 2022 20:48:47 GMT, Vladimir Ivanov <vliva...@openjdk.org> wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 21 commits: >> >> - Merge branch 'foreign-preview-m' into JEP-19-VM-IMPL2 >> - Remove unneeded ComputeMoveOrder >> - Remove comment about native calls in lcm.cpp >> - 8284072: foreign/StdLibTest.java randomly crashes on MacOS/AArch64 >> >> Reviewed-by: jvernee, mcimadamore >> - Update riscv and arm stubs >> - Remove spurious ProblemList change >> - Pass pointer to LogStream >> - Polish >> - Replace TraceNativeInvokers flag with unified logging >> - Fix other platforms, take 2 >> - ... and 11 more: >> https://git.openjdk.java.net/jdk/compare/3c88a2ef...43fd1b91 > > src/hotspot/share/prims/foreign_globals.hpp line 35: > >> 33: #include CPU_HEADER(foreign_globals) >> 34: >> 35: class CallConvClosure { > > Just a question on terminology: why is it called a `Closure`? It is the terminology used in other parts of hotspot for function objects it seems. See for instance the classes in `iterator.hpp` > src/hotspot/share/prims/foreign_globals.hpp line 62: > >> 60: >> 61: >> 62: class JavaCallConv : public CallConvClosure { > > Does it really worth to abbreviate `CallingConvention` to `CallConv`? Maybe not... I'll spell out the full thing. ------------- PR: https://git.openjdk.java.net/jdk/pull/7959
