On Wed, 11 May 2022 13:35:43 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Avoid pragma error in before GCC 12
>
> src/hotspot/share/utilities/compilerWarnings_gcc.hpp line 51:
>
>> 49:
>> 50: #define PRAGMA_STRINGOP_OVERFLOW_IGNORED \
>> 51: PRAGMA_DISABLE_GCC_WARNING("-Wstringop-overflow")
>
> Are the reported problems with format/stringop-overflow real? Or are they
> false positives? If they are real then I'm not going to approve ignoring them,
> unless there is some urgent reason and there are followup bug reports for
> fixing them.
I think all of warnings in HotSpot are false-positives, so I added new pragmas
to compilerWarnings.hpp, and use it in HotSpot code.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8646
