On Thu, 12 May 2022 00:26:41 GMT, Yasumasa Suenaga <ysuen...@openjdk.org> wrote:

>> I don't understand what the actual warning is getting at .. can anyone 
>> explain it ?
>> FWIW the code is still the same in upstream harfbuzz
>> https://github.com/harfbuzz/harfbuzz/blob/main/src/hb-font.cc
> I've pasted a part of warning messages to description of this PR, all of 
> messages are here:
> In function 'void trampoline_reference(hb_trampoline_closure_t*)',
>     inlined from 'void hb_font_funcs_set_glyph_func(hb_font_funcs_t*, 
> hb_font_get_glyph_func_t, void*, hb_destroy_func_t)' at 
> /home/ysuenaga/github-forked/jdk/src/java.desktop/share/native/libharfbuzz/hb-font.cc:2368:24:

So upstream say it is not a problem since the analysis overlooks that it would 
not reach that free if it were immutable because of a previous check. I guess 
we disable the false positive warning for now.


PR: https://git.openjdk.java.net/jdk/pull/8646

Reply via email to