On Sat, 29 Oct 2022 14:16:24 GMT, Alan Bateman <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Updated after review comments. In particular var tmp => var => _unused -
>> and avoid var in java.xml
>> - Merge branch 'master' into deprecate-url-ctor-8294241
>> - Fix whitespace issues
>> - 8294241
>
> src/java.base/share/classes/java/net/URL.java line 157:
>
>> 155: * The URL constructors are specified to throw
>> 156: * {@link MalformedURLException} but the actual parsing/validation
>> 157: * that are performed is implementation dependent. Some
>> parsing/validation
>
> "the ... are performed" -> "the ... is performed".
done
> src/java.base/share/classes/java/net/URL.java line 852:
>
>> 850: * @since 20
>> 851: */
>> 852: public static URL of(URI uri, URLStreamHandler streamHandler)
>
> The parameter is named "handler" rather than "streamHandler" in constructors
> so we should probably keep it the same to avoid any confusion.
done
-------------
PR: https://git.openjdk.org/jdk/pull/10874
