On Sat, 29 Oct 2022 14:17:12 GMT, Alan Bateman <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Updated after review comments. In particular var tmp => var => _unused -
>> and avoid var in java.xml
>> - Merge branch 'master' into deprecate-url-ctor-8294241
>> - Fix whitespace issues
>> - 8294241
>
> src/java.base/share/classes/java/net/URL.java line 166:
>
>> 164: * The {@code java.net.URL} constructors are deprecated.
>> 165: * Developers are encouraged to use {@link URI java.net.URI} to parse
>> 166: * or construct any {@code URL}. In cases where an instance of {@code
>
> "any URL" -> "a URL" or "all URLs".
done
> src/java.base/share/classes/java/net/URL.java line 168:
>
>> 166: * or construct any {@code URL}. In cases where an instance of {@code
>> 167: * java.net.URL} is needed to open a connection, {@link URI} can be used
>> 168: * to construct or parse the URL string, possibly calling {@link
>
> I wonder if it might be clearer to say "url string", only to avoid anyone
> thinking they call URL::toString.
I don't believe it would be syntactically correct to put it in all lower case
since URL is an acronym. I could replace it with "URI string" instead but I'm
not sure it would be better. What do you think?
-------------
PR: https://git.openjdk.org/jdk/pull/10874
