On Sat, 29 Oct 2022 14:24:09 GMT, Alan Bateman <[email protected]> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Updated after review comments. In particular var tmp => var => _unused -
>> and avoid var in java.xml
>> - Merge branch 'master' into deprecate-url-ctor-8294241
>> - Fix whitespace issues
>> - 8294241
>
> src/java.base/share/classes/java/net/URL.java line 133:
>
>> 131: * specified. The optional fragment is not inherited.
>> 132: *
>> 133: * <h2><a id="constructor-deprecation"></a>Constructing instances of
>> {@code URL}</h2>
>
> Would it be better to move the anchor to line 164 (the line where it says
> that the URL constructors are deprecated?
To be discussed: I actually wanted the deprecation link ( the link from
`@deprecated` ) to lead here because I find that the whole section is relevant
for developers who might want to decide whether to actually move away from
using constructors, or be tempted to just use `@SuppressWarnings`.
-------------
PR: https://git.openjdk.org/jdk/pull/10874
