On Mon, 20 May 2024 10:11:26 GMT, David Holmes <[email protected]> wrote:
>> Axel Boldt-Christmas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright year
>
> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691:
>
>> 689: * @throws RuntimeException If the pattern was not found
>> 690: */
>> 691: public OutputAnalyzer
>> stderrShouldMatchIgnoreDeprecatedWarnings(String pattern) {
>
> Given we have `...IgnoreVMWarnings` this special case should really be called
> `...IgnoreDeprecatedVMWarnings`.
The name was chosen based on:
https://github.com/openjdk/jdk/blob/77c8516085225a04bd5a954197fc5ef7e5c5ee61/test/lib/jdk/test/lib/process/OutputAnalyzer.java#L184
Should I still change it?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19297#discussion_r1606671332
