On Mon, 20 May 2024 11:41:48 GMT, Axel Boldt-Christmas <abold...@openjdk.org> wrote:
>> test/lib/jdk/test/lib/process/OutputAnalyzer.java line 691: >> >>> 689: * @throws RuntimeException If the pattern was not found >>> 690: */ >>> 691: public OutputAnalyzer >>> stderrShouldMatchIgnoreDeprecatedWarnings(String pattern) { >> >> Given we have `...IgnoreVMWarnings` this special case should really be >> called `...IgnoreDeprecatedVMWarnings`. > > The name was chosen based on: > https://github.com/openjdk/jdk/blob/77c8516085225a04bd5a954197fc5ef7e5c5ee61/test/lib/jdk/test/lib/process/OutputAnalyzer.java#L184 > > Should I still change it? No. Sorry I missed the fact the inconsistency had already been introduced. And given that function exists we may as well add the new one too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19297#discussion_r1607458481