On Thu, 10 Apr 2025 08:31:40 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix comment from file.encoding to native.encoding > > src/java.base/share/classes/jdk/internal/util/SystemProps.java line 79: > >> 77: // Platform defined encodings cannot be overridden on the >> command line >> 78: put(props, "sun.jnu.encoding", >> raw.propDefault(Raw._sun_jnu_encoding_NDX)); >> 79: var nativeEncoding = raw.propDefault(Raw._native_encoding_NDX); > > I'd prefer not see "var" here, only because it's not immediately clear that > nativeEncoding is a String. I changed this `var` to `String` and also another occurrence a few lines below. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24463#discussion_r2037992031
