On Thu, 10 Apr 2025 18:11:06 GMT, Stuart Marks <sma...@openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 79:
>> 
>>> 77:         // Platform defined encodings cannot be overridden on the 
>>> command line
>>> 78:         put(props, "sun.jnu.encoding", 
>>> raw.propDefault(Raw._sun_jnu_encoding_NDX));
>>> 79:         var nativeEncoding = raw.propDefault(Raw._native_encoding_NDX);
>> 
>> I'd prefer not see "var" here, only because it's not immediately clear that 
>> nativeEncoding is a String.
>
> I changed this `var` to `String` and also another occurrence a few lines 
> below.

Also, I updated copyrights.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24463#discussion_r2037992391

Reply via email to