On Tue, 15 Apr 2025 17:12:18 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> src/java.base/share/native/libjava/System.c line 151: >> >>> 149: /* basic encoding properties, always non-NULL */ >>> 150: PUTPROP(propArray, _native_encoding_NDX, sprops->encoding); >>> 151: PUTPROP(propArray, _sun_jnu_encoding_NDX, >>> sprops->sun_jnu_encoding); >> >> Since we now got rid of platform depenence here, would it make sense to >> perform non-null assertion in Java level here? I remember in the last PR we >> added `assert` in platform C code. > > `Java level` -> `Platform independent C level` > Sorry Good idea. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24607#discussion_r2045929780
