On Wed, 16 Apr 2025 13:20:33 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Stuart Marks has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Move asserts into platform-independent code. >> - Merge branch 'master' into JDK-8354464-additional-cleanup-native-encoding >> - Rename variables to make clear they're not used. >> - 8354464: Additional cleanup setting up native.encoding > > I've gone through this, I don't see any issues. Sorry, @AlanBateman and @naotoj and I have been over this code a bunch of times, and I thought their reviews were sufficient. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24607#issuecomment-2814064006
