On Tue, 6 May 2025 09:21:24 GMT, Shaojin Wen <[email protected]> wrote:
>> Per Minborg has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Fix empty line at the end of a third file
>> - Fix empty line at the end of another file
>> - Fix empty line at the end of a file
>
> src/java.base/share/classes/jdk/internal/foreign/CaptureStateUtil.java line
> 306:
>
>> 304: @ForceInline
>> 305: private static int success(int value,
>> 306: MemorySegment segment) {
>
> Suggestion:
>
> private static long success(long value, MemorySegment segment) {
>
> Newline separation is not necessary here
I've taken the approach to always separate parameters in this class.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25043#discussion_r2075353554
