Re: RFR: 8347408: Create an internal method handle adapter for system calls with errno [v4]

[Shaojin Wen]

On Tue, 6 May 2025 12:32:38 GMT, Per Minborg <pminb...@openjdk.org> wrote:

>> As we advance, converting older JDK code to use the relatively new FFM API 
>> requires system calls that can provide `errno` and the likes to explicitly 
>> allocate a MemorySegment to capture potential error states. This can lead to 
>> negative performance implications if not designed carefully and also 
>> introduces unnecessary code complexity.
>> 
>> Hence, this PR proposes adding a JDK internal method handle adapter that can 
>> be used to handle system calls with `errno`, `GetLastError`, and 
>> `WSAGetLastError`.
>> 
>> It relies on an efficient carrier-thread-local cache of memory regions to 
>> allide allocations.
>
> Per Minborg has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Address comments

src/java.base/share/classes/jdk/internal/foreign/CaptureStateUtil.java line 121:

> 119:             return obj instanceof BasicKey that &&
> 120:                     returnType.equals(that.returnType) &&
> 121:                     stateName.equals(that.stateName);

Suggestion:

            return obj instanceof BasicKey that
                    && returnType.equals(that.returnType)
                    && stateName.equals(that.stateName);

In the JDK source code, the operator && is placed in front in most cases.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25043#discussion_r2076688887