On Thu, 15 May 2025 18:27:35 GMT, David Beaumont <d...@openjdk.org> wrote:
>> Adding read-only support to ZipFileSystem.
>>
>> The new `accessMode` environment property allows for readOnly and readWrite
>> values, and ensures that the requested mode is consistent with what's
>> returned.
>>
>> This involved a little refactoring to ensure that "read only" state was set
>> initially and only unset at the end of initialization if appropriate.
>>
>> By making 2 methods return values (rather than silently set non-final fields
>> as a side effect) it's now clear in what order fields are initialized and
>> which are final (sadly there are still non-final fields, but only a split of
>> this class into two types can fix that, since determining multi-jar support
>> requires reading the file system).
>
> David Beaumont has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Changes based on review feedback.
src/jdk.zipfs/share/classes/module-info.java line 299:
> 297: * <li>
> 298: * Any other values will cause an {@code
> IllegalArgumentException}
> 299: * to be thrown.
The wording looks great. Just one thing with the "causes an IAE to be thrown"
where I think it can be expanded to say that it causes IAE to be thrown when
attempting to create the ZIP file system. The existing compressMethod property
has word for this too.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2092352639
