On Wed, 14 May 2025 16:42:07 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes based on review feedback.
>
> test/jdk/jdk/nio/zipfs/TestPosix.java line 434:
>
>> 432: createTestZipFile(ZIP_FILE, ENV_DEFAULT).close();
>> 433: // check entries on zipfs with default options
>> 434: try (FileSystem zip = FileSystems.newFileSystem(ZIP_FILE,
>> ENV_DEFAULT)) {
>
> This tests an empty Map and should still be a test as it is different from
> ENV_READ_ONLY
Revert and added new ReadOnly variants of those tests. Thanks for calling me
out on this, it was a bit sloppy of me.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2095503763
