On Fri, 16 May 2025 15:38:33 GMT, Lance Andersen <lan...@openjdk.org> wrote:
>> src/jdk.zipfs/share/classes/module-info.java line 299: >> >>> 297: * <li> >>> 298: * Any other values will cause an {@code >>> IllegalArgumentException} >>> 299: * to be thrown. >> >> The wording looks great. Just one thing with the "causes an IAE to be >> thrown" where I think it can be expanded to say that it causes IAE to be >> thrown when attempting to create the ZIP file system. The existing >> compressMethod property has word for this too. > > The IAE message would be best to standardize around the wording that the > compressMethod property uses (same for releaseVersion while we are at it. Done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25178#discussion_r2095504122