On Tue, 28 Oct 2025 10:34:54 GMT, Daniel Jeliński <[email protected]> wrote:
> Nice cleanup! > > [This > line](https://github.com/openjdk/jdk/blob/9625993611bb6acf84d428bea4a65d33b9d66e5f/test/micro/org/openjdk/bench/jdk/internal/jrtfs/ImageReaderBenchmark.java#L1065) > should probably be removed. Good catch. I need to go back and check why my search didn't find this one. I'll update the PR shortly. > src/java.base/share/classes/jdk/internal/loader/Resource.java line 133: > >> 131: */ >> 132: public ByteBuffer getByteBuffer() throws IOException { >> 133: InputStream in = cachedInputStream(); > > The method documentation could use a cleanup as well. Hello Daniel, i did consider that too but decided not to change it because there are implementations of `Resource` class which override this method to indeed return a `ByteBuffer` for certain implementations. Of course in those implementations they don't use the obsolete `ByteBuffered` interface. The javadoc text appeared generic enough to leave it in the current form. ------------- PR Comment: https://git.openjdk.org/jdk/pull/28016#issuecomment-3455873612 PR Review Comment: https://git.openjdk.org/jdk/pull/28016#discussion_r2469054578
