On Tue, 28 Oct 2025 13:05:41 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which removes an obsolete internal >> interface? >> >> The `sun.nio.ByteBuffered` interface is internal to the java.base module and >> does not have any implementations in the JDK. The only place where we use >> this is in `jdk.internal.loader.Resource` (another internal class within >> java.base). The usage itself is a mere `instanceof` check against the >> `InputStream` corresponding to that `Resource`. Given that there are no >> implementations of this interface, that check is redundant. >> >> tier testing is currently in progress with this change, and given the nature >> of this change, no new tests have been introduced. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > remove reference from ImageReaderBenchmark Marked as reviewed by djelinski (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/28016#pullrequestreview-3389137143
