> Can I please get a review of this change which removes an obsolete internal 
> interface?
> 
> The `sun.nio.ByteBuffered` interface is internal to the java.base module and 
> does not have any implementations in the JDK. The only place where we use 
> this is in `jdk.internal.loader.Resource` (another internal class within 
> java.base). The usage itself is a mere `instanceof` check against the 
> `InputStream` corresponding to that `Resource`. Given that there are no 
> implementations of this interface, that check is redundant.
> 
> tier testing is currently in progress with this change, and given the nature 
> of this change, no new tests have been introduced.

Jaikiran Pai has updated the pull request incrementally with one additional 
commit since the last revision:

  remove reference from ImageReaderBenchmark

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28016/files
  - new: https://git.openjdk.org/jdk/pull/28016/files/8a37155f..511ffd97

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28016&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28016&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/28016.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28016/head:pull/28016

PR: https://git.openjdk.org/jdk/pull/28016

Reply via email to