On Mon, 1 Dec 2025 16:08:35 GMT, Jaikiran Pai <[email protected]> wrote:
>> Can I please get a review of this change which proposes to address the issue >> noted in https://bugs.openjdk.org/browse/JDK-8372787? >> >> The commit in this PR updates several methods in the >> `jdk.internal.module.ModulePatcher$PatchedModuleReader` to throw an >> `IOException` if the `ModuleReader` has been closed. This updated >> implementation now matches the specification of the corresponding methods in >> `ModuleReader`. >> >> A new jtreg test has been introduced to reproduce the issue and verify the >> fix. CI testing is currently in progress with this change. > > Jaikiran Pai has updated the pull request incrementally with one additional > commit since the last revision: > > rename test methods test/jdk/java/lang/module/ModuleReader/patched/PatchedModuleReaderTest.java line 66: > 64: Optional<URI> res = reader.find(resourceName); > 65: assertTrue(res.isPresent(), resourceName + " is missing in " > 66: + patchedModuleRef.descriptor().name() + " module"); A suggestion here is replace this assert with a more complete test to check that the URI's scheme is "file" and that its path component ends with "java/lang/PatchedFoo.class". ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28569#discussion_r2577780963
