> Can I please get a review of this change which proposes to address the issue > noted in https://bugs.openjdk.org/browse/JDK-8372787? > > The commit in this PR updates several methods in the > `jdk.internal.module.ModulePatcher$PatchedModuleReader` to throw an > `IOException` if the `ModuleReader` has been closed. This updated > implementation now matches the specification of the corresponding methods in > `ModuleReader`. > > A new jtreg test has been introduced to reproduce the issue and verify the > fix. CI testing is currently in progress with this change.
Jaikiran Pai has updated the pull request incrementally with three additional commits since the last revision: - return early if already closed() - fix summary line - even test for ModuleReader.list() on a closed ModuleReader ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28569/files - new: https://git.openjdk.org/jdk/pull/28569/files/adf5feb1..6359d3c6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28569&range=05-06 Stats: 8 lines in 2 files changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/28569.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28569/head:pull/28569 PR: https://git.openjdk.org/jdk/pull/28569
