On Mon, 1 Dec 2025 16:27:20 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> rename test methods > > test/jdk/java/lang/module/ModuleReader/patched/PatchedModuleReaderTest.java > line 66: > >> 64: Optional<URI> res = reader.find(resourceName); >> 65: assertTrue(res.isPresent(), resourceName + " is missing in " >> 66: + patchedModuleRef.descriptor().name() + " module"); > > A suggestion here is replace this assert with a more complete test to check > that the URI's scheme is "file" and that its path component ends with > "java/lang/PatchedFoo.class". Done. The test continues to pass with this change. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28569#discussion_r2577830144
