On Wed, 3 Dec 2025 03:20:45 GMT, Alexander Matveev <[email protected]> wrote:
> - Added logging of sign commands.
> - Sign commands will be logged with `DEBUG` level. Skipped files and
> signature removal with `TRACE` to reduce amount of less important messages.
> - Renamed `unsign` to `removeSignature`. I think it is better name.
> - Removed `sign` and `codesigners.accept(path)` will be used instead. Not
> sure why we need function with one line and we using
> `codesigners.accept(path)` in other places anyway.
> - Direct call to `codesigners.codesignDir().accept(path)` was changed to
> `codesigners.accept(path)`. In this case exception will be logged if
> `codesignDir` is not available and I think it is better for
> `codesigners.accept(path)` to select code signer vs calling it directly.
src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/AppImageSigner.java line
237:
> 235: findCodesigner(path).orElseThrow(() -> {
> 236: LOGGER.log(Level.ERROR, "No codesigner for {0} path",
> 237: PathUtils.normalizedAbsolutePathString(path));
This log statement is redundant. There is no point in logging exceptions being
thrown. It is sufficient to log the caught exceptions if the log messages
include exception stack traces.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28623#discussion_r2585598635
