> - Added logging of sign commands. > - Sign commands will be logged with `DEBUG` level. Skipped files and > signature removal with `TRACE` to reduce amount of less important messages. > - Renamed `unsign` to `removeSignature`. I think it is better name. > - Removed `sign` and `codesigners.accept(path)` will be used instead. Not > sure why we need function with one line and we using > `codesigners.accept(path)` in other places anyway. > - Direct call to `codesigners.codesignDir().accept(path)` was changed to > `codesigners.accept(path)`. In this case exception will be logged if > `codesignDir` is not available and I think it is better for > `codesigners.accept(path)` to select code signer vs calling it directly.
Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision: 8356116: [macos] Add logging of sign commands in jpackage [v2] ------------- Changes: - all: https://git.openjdk.org/jdk/pull/28623/files - new: https://git.openjdk.org/jdk/pull/28623/files/eb34f609..d2f81fc3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=28623&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28623&range=00-01 Stats: 10 lines in 1 file changed: 1 ins; 7 del; 2 mod Patch: https://git.openjdk.org/jdk/pull/28623.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/28623/head:pull/28623 PR: https://git.openjdk.org/jdk/pull/28623
