On Wed, 3 Dec 2025 15:41:13 GMT, Alexey Semenyuk <[email protected]> wrote:
>> - Added logging of sign commands.
>> - Sign commands will be logged with `DEBUG` level. Skipped files and
>> signature removal with `TRACE` to reduce amount of less important messages.
>> - Renamed `unsign` to `removeSignature`. I think it is better name.
>> - Removed `sign` and `codesigners.accept(path)` will be used instead. Not
>> sure why we need function with one line and we using
>> `codesigners.accept(path)` in other places anyway.
>> - Direct call to `codesigners.codesignDir().accept(path)` was changed to
>> `codesigners.accept(path)`. In this case exception will be logged if
>> `codesignDir` is not available and I think it is better for
>> `codesigners.accept(path)` to select code signer vs calling it directly.
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/Executor.java line 1:
>
>> 1: /*
>
> The changes to this file imply that logging external commands that jpackage
> runs is optional. Is it? Why would we want to log some commands but not all?
MAIN("jdk.jpackage"),
MAC_SIGN("jdk.jpackage.mac-sign"),
LINUX_LIBS("jdk.jpackage.linux-libs"),
In my understanding we have 3 types of loggers. MAIN and MAC_SIGN we need to
log command executions. Not sure about LINUX_LIBS. If we log always using MAIN,
then signing will be partially logged with MAIN and fully logged with MAC_SIGN.
Not sure what is right solution here. Do we need to log sign commands for MAIN?
or just with MAC_SIGN? If we log for MAIN, then when to log skipped files for
example or execution of signature removal commands?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28623#discussion_r2586913001
