> - Move code shared between jpackage's Executor and jpackage's test lib 
> Executor into `jdk.jpackage.internal.util.CommandOutputControl` class using 
> the latter one as the baseline for the new class; [CommandOutputControl class 
> javadoc](https://alexeysemenyukoracle.github.io/jpackage-javadoc/jdk.jpackage/jdk/jpackage/internal/util/CommandOutputControl.html).
> - Place "execute with retries" logic into 
> `jdk.jpackage.internal.util.RetryExecutor` class and use it from both 
> jpackage and jpackage's test lib. Use `jdk.jpackage.internal.RetryExecutor` 
> class as the baseline.
> - Add `ObjectFactory`, `ExecutorFactory`, and `RetryExecutorFactory` 
> interfaces to the "jdk.jpackage.internal" package. They enable the use of 
> command mocks with jpackage.
> - Add `jdk.jpackage.test.mock` package. It facilitates creating command 
> mocks. Use it to test LibProvidersLookup, LinuxSystemEnvironment, 
> LinuxPackageArch, MacDmgSystemEnvironment, and MacDmgPackager classes.
> 
> Supplementary changes:
>  - Make `jdk.jpackage.internal.SystemEnvironment` and all implementing 
> classes package private

Alexey Semenyuk has updated the pull request incrementally with one additional 
commit since the last revision:

  test/Executor: minor fix

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28733/files
  - new: https://git.openjdk.org/jdk/pull/28733/files/70d7de8d..0be4bdb9

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28733.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28733/head:pull/28733

PR: https://git.openjdk.org/jdk/pull/28733

Reply via email to