On Tue, 6 Jan 2026 22:32:33 GMT, Alexey Semenyuk <[email protected]> wrote:

>> - Move code shared between jpackage's Executor and jpackage's test lib 
>> Executor into `jdk.jpackage.internal.util.CommandOutputControl` class using 
>> the latter one as the baseline for the new class; [CommandOutputControl 
>> class 
>> javadoc](https://alexeysemenyukoracle.github.io/jpackage-javadoc/jdk.jpackage/jdk/jpackage/internal/util/CommandOutputControl.html).
>> - Place "execute with retries" logic into 
>> `jdk.jpackage.internal.util.RetryExecutor` class and use it from both 
>> jpackage and jpackage's test lib. Use `jdk.jpackage.internal.RetryExecutor` 
>> class as the baseline.
>> - Add `ObjectFactory`, `ExecutorFactory`, and `RetryExecutorFactory` 
>> interfaces to the "jdk.jpackage.internal" package. They enable the use of 
>> command mocks with jpackage.
>> - Add `jdk.jpackage.test.mock` package. It facilitates creating command 
>> mocks. Use it to test LibProvidersLookup, LinuxSystemEnvironment, 
>> LinuxPackageArch, MacDmgSystemEnvironment, and MacDmgPackager classes.
>> 
>> Supplementary changes:
>>  - Make `jdk.jpackage.internal.SystemEnvironment` and all implementing 
>> classes package private
>
> Alexey Semenyuk has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   test/Executor: minor fix

- Address all review comments
- Update the patch with changes from a separate project based on this PR

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28733#issuecomment-3721522513

Reply via email to