> - Move code shared between jpackage's Executor and jpackage's test lib
> Executor into `jdk.jpackage.internal.util.CommandOutputControl` class using
> the latter one as the baseline for the new class; [CommandOutputControl class
> javadoc](https://alexeysemenyukoracle.github.io/jpackage-javadoc/jdk.jpackage/jdk/jpackage/internal/util/CommandOutputControl.html).
> - Place "execute with retries" logic into
> `jdk.jpackage.internal.util.RetryExecutor` class and use it from both
> jpackage and jpackage's test lib. Use `jdk.jpackage.internal.RetryExecutor`
> class as the baseline.
> - Add `ObjectFactory`, `ExecutorFactory`, and `RetryExecutorFactory`
> interfaces to the "jdk.jpackage.internal" package. They enable the use of
> command mocks with jpackage.
> - Add `jdk.jpackage.test.mock` package. It facilitates creating command
> mocks. Use it to test LibProvidersLookup, LinuxSystemEnvironment,
> LinuxPackageArch, MacDmgSystemEnvironment, and MacDmgPackager classes.
>
> Supplementary changes:
> - Make `jdk.jpackage.internal.SystemEnvironment` and all implementing
> classes package private
Alexey Semenyuk has updated the pull request incrementally with one additional
commit since the last revision:
Rework JPackageCommand#withToolProvider() to run workload in a new native
thread instead of a virtual thread from a pool. Pooled and/or virtual threads
are problematic when used with inheritable thread-local variables. TKit class
depends on such a variable, which results in intermittent test failure:
java.util.concurrent.CompletionException: java.lang.NullPointerException:
Cannot invoke "jdk.jpackage.test.TestInstance.workDir()" because the return
value of "jdk.jpackage.test.TKit.currentTest()" is null
at
java.base/java.util.concurrent.CompletableFuture.wrapInCompletionException(CompletableFuture.java:323)
at
java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:359)
at
java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:364)
at
java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1828)
at
java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1817)
at
java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:511)
at
java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1436)
at
java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:2011)
at
java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:187)
Caused by: java.lang.NullPointerException: Cannot invoke
"jdk.jpackage.test.TestInstance.workDir()" because the return value of
"jdk.jpackage.test.TKit.currentTest()" is null
at jdk.jpackage.test.TKit.workDir(TKit.java:244)
at
jdk.jpackage.test.JPackageCommand.setDefaultInputOutput(JPackageCommand.java:280)
at
jdk.jpackage.test.JPackageCommand.helloAppImage(JPackageCommand.java:384)
at
jdk.jpackage.test.JPackageCommand.helloAppImage(JPackageCommand.java:361)
at
jdk.jpackage/jdk.jpackage.internal.cli.MainTest.lambda$testFailedCommandOutput$2(MainTest.java:123)
at
jdk.jpackage.test.JPackageCommand.lambda$withToolProvider$0(JPackageCommand.java:805)
at
java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1825)
... 5 more
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/28733/files
- new: https://git.openjdk.org/jdk/pull/28733/files/b5bb8134..538ed989
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=28733&range=02-03
Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/28733.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28733/head:pull/28733
PR: https://git.openjdk.org/jdk/pull/28733
