On Fri, 16 Jan 2026 02:03:03 GMT, Alexander Matveev <[email protected]> wrote:
> I think we need ability to pass additional arguments to > setFakeRuntime(String version) To suit the needs of a single test? Any chance we need a fake runtime with the "release" file in other tests? > In this case we will have `createInputRuntimeImage(RuntimeImageType role, > String version)` Two major problems with this approach: - Eventually, we will end up with `createInputRuntimeImage(RuntimeImageType role, String version, String fooProperty, boolean barProperty, Date dateProperty)` signature. Which will be unreadable, just like we had it at https://github.com/openjdk/jdk/blob/6c48f4ed707bf0b15f9b6098de30db8aae6fa40f/src/jdk.jpackage/share/classes/jdk/jpackage/internal/IOUtils.java#L108 The calls will be equally unreadable to: https://github.com/openjdk/jdk/blob/6c48f4ed707bf0b15f9b6098de30db8aae6fa40f/src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgPackager.java#L330 - When the external runtime is specified for the test with the "jdk.jpackage.runtime-image" system property, what to do with the "version" parameter? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29205#discussion_r2696835672
