On Fri, 16 Jan 2026 02:49:41 GMT, Alexander Matveev <[email protected]> wrote:
>> Refactor signing tests covering gaps listed in the [CR >> description](https://bugs.openjdk.org/browse/JDK-8375242). >> >> Old test signatures: >> >> SigningAppImageTest.test(true, true, ASCII_INDEX) >> SigningAppImageTest.test(true, true, UNICODE_INDEX) >> SigningAppImageTest.test(true, false, UNICODE_INDEX) >> SigningAppImageTest.test(false, true, INVALID_INDEX) >> >> SigningAppImageTwoStepsTest.test(true, true) >> SigningAppImageTwoStepsTest.test(true, false) >> SigningAppImageTwoStepsTest.test(false, true) >> >> SigningPackageTest.test(true, true, true, ASCII_INDEX) >> SigningPackageTest.test(true, true, true, UNICODE_INDEX) >> SigningPackageTest.test(false, true, true, UNICODE_INDEX) >> SigningPackageTest.test(false, true, false, UNICODE_INDEX) >> SigningPackageTest.test(false, false, true, UNICODE_INDEX) >> >> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}; {MAC_DMG={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}, MAC_PKG={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, >> ...]}}) >> SigningPackageTwoStepTest.test({MAC_DMG={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}, MAC_PKG={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, >> ...]}}) >> SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}) >> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}; {MAC_DMG={--mac-app-image-sign-identity: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}, MAC_PKG={--mac-installer-sign-identity: >> CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, >> ...]}}) >> SigningPackageTwoStepTest.test({MAC_DMG={--mac-app-image-sign-identity: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}, MAC_PKG={--mac-installer-sign-identity: >> CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, >> ...]}}) >> SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: >> CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, >> ...]}) >> >> Si... > > test/jdk/tools/jpackage/macosx/SigningBase.java line 2: > >> 1: /* >> 2: * Copyright (c) 2019, 2026, Oracle and/or its affiliates. All rights >> reserved. > > Do you know why moving this file is not recorded as rename? Absolutely no idea. I may be able to fix this by using `git mv` command, ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29205#discussion_r2696846668
