On Tue, 13 Jan 2026 18:23:00 GMT, Alexey Semenyuk <[email protected]> wrote:
> Refactor signing tests covering gaps listed in the [CR > description](https://bugs.openjdk.org/browse/JDK-8375242). > > Old test signatures: > > SigningAppImageTest.test(true, true, ASCII_INDEX) > SigningAppImageTest.test(true, true, UNICODE_INDEX) > SigningAppImageTest.test(true, false, UNICODE_INDEX) > SigningAppImageTest.test(false, true, INVALID_INDEX) > > SigningAppImageTwoStepsTest.test(true, true) > SigningAppImageTwoStepsTest.test(true, false) > SigningAppImageTwoStepsTest.test(false, true) > > SigningPackageTest.test(true, true, true, ASCII_INDEX) > SigningPackageTest.test(true, true, true, UNICODE_INDEX) > SigningPackageTest.test(false, true, true, UNICODE_INDEX) > SigningPackageTest.test(false, true, false, UNICODE_INDEX) > SigningPackageTest.test(false, false, true, UNICODE_INDEX) > > SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}; {MAC_DMG={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}, MAC_PKG={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, > ...]}}) > SigningPackageTwoStepTest.test({MAC_DMG={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}, MAC_PKG={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, > ...]}}) > SigningPackageTwoStepTest.test(app-image={--mac-signing-key-user-name: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}) > SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}; {MAC_DMG={--mac-app-image-sign-identity: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}, MAC_PKG={--mac-installer-sign-identity: > CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, > ...]}}) > SigningPackageTwoStepTest.test({MAC_DMG={--mac-app-image-sign-identity: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}, MAC_PKG={--mac-installer-sign-identity: > CertificateRequest[name=Developer ID Installer: jpackage.openjdk.java.net, > ...]}}) > SigningPackageTwoStepTest.test(app-image={--mac-app-image-sign-identity: > CertificateRequest[name=Developer ID Application: jpackage.openjdk.java.net, > ...]}) > > SigningRuntimeImagePackageTest.test(true, INVALID_INDEX,... This pull request has now been integrated. Changeset: 9b47c23b Author: Alexey Semenyuk <[email protected]> URL: https://git.openjdk.org/jdk/commit/9b47c23b4b809f7070c6c8279b7ffdf83234dcdb Stats: 1943 lines in 13 files changed: 974 ins; 550 del; 419 mod 8375242: [macos] Improve jpackage signing coverage Reviewed-by: almatvee ------------- PR: https://git.openjdk.org/jdk/pull/29205
