On Fri, 16 Jan 2026 04:31:54 GMT, Alexander Matveev <[email protected]> 
wrote:

>> Sorry, I still don't get it. jpackage doesn't run normalization on the 
>> version it reads from the "release" file, right? Why does the testing code 
>> do it?
>
> jpackage will normalize macOS version read from release file to 3 components 
> and Windows to 4 components. See `MacFromOptions` and `WinApplication`. 
> Normalization is done for application and package builder just use it from 
> application. macOS limits application version CFBundleVersion to 3 
> components, thus to align with Windows it was limited to 3. Testing code 
> needs to do same.

Never mind, I assumed that version normalization would be implemented only on 
Windows, based on our offline conversation yesterday. But it applies to both 
macOS and Windows. So the function itself is alright, only the signature needs 
updating

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2696871654

Reply via email to