On Fri, 16 Jan 2026 04:04:56 GMT, Alexander Matveev <[email protected]> wrote:
>> - Version will be read from JDK's release file if not provided via >> `--version` for runtime installer. >> - Added test to cover added functionality. >> - On macOS and Windows version from JDK's release file will be normalized if >> it does not fit platform requirements. > > Alexander Matveev has updated the pull request incrementally with one > additional commit since the last revision: > > 8357404: jpackage should attempt to get a package version from the JDK's > release file if the --version option is not specified [v4] There is duplicated code in the MacFromOptions and WinFromOptions classes. I suggest moving it into `Application ApplicationBuilder.normalizeVersion(Application app, UnaryOperator<String> versionNormalizer)` utility function. This class already has code copying Application instances with mods. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29260#issuecomment-3758127555
