On Fri, 16 Jan 2026 23:31:01 GMT, Alexey Semenyuk <[email protected]> wrote:
> > Why we need to normalize version then? > > Same reason why we do this for the app version in the "release" file. Why > would it be different? > > > For example jar can have: 1.2.3-SNAPSHOT. In this case JarVersionReader > > will return 1.2.3 > > * What would `RuntimeVersionReader` and `ModuleVersionReader` return for this > input? > * Why would the `JarVersionReader` strip the "-SNAPSHOT" prefix? On Linux, > there are no restrictions similar to those of macOS and Windows for version > string. "1.2.3-SNAPSHOT" is a valid rpm/deb version. On macOS when generating runtime installer DMG package version is only used in file name. For example `TestJDK-27.0.0.dmg`. Which makes `1.2.3-SNAPSHOT` valid version for macOS runtime installer DMG case. I think we need follow up bug to figure out all possible combinations on how version is being used and normalized it for specific cases. ------------- PR Comment: https://git.openjdk.org/jdk/pull/29260#issuecomment-3762596166
