On Tue, 3 Mar 2026 02:09:52 GMT, Alexander Matveev <[email protected]> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> > > src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacDmgSystemEnvironment.java > line 54: > >> 52: .toList(); >> 53: } else { >> 54: // The code runs on an OS other than macOS. Presume this is >> mock testing. > > I might be wrong, but code under "jdk.jpackage/macos" is not included during > build time on other platforms. Do we plan to add all platform specific code > to other platforms during build time? Will we move all code under "share"? You are right. We will not add all platform-specific code to other platforms during build time in regular JDK builds. This change facilitates local dev builds in which jpackage is built from sources from all platforms. > Will we move all code under "share"? No. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2875880859
