On Tue, 3 Mar 2026 02:44:03 GMT, Alexander Matveev <[email protected]> wrote:
>> Alexey Semenyuk has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update test/jdk/tools/jpackage/helpers/jdk/jpackage/test/AppImageFile.java >> >> Co-authored-by: Andrey Turbanov <[email protected]> > > test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JavaTool.java line 54: > >> 52: private Path relativePathInJavaHome() { >> 53: Path path = Path.of("bin", toolName()); >> 54: if (OperatingSystem.isWindows()) { > > Should we use `TKit` for OS check in test code? Above you changed from > `OperatingSystem` to `TKit` and here is opposite. These changes are intentional. The path to a JDK tool is always specific to the real OS. In cases where TKit simulates execution on an OS that differs from the one returned by `OperatingSystem.current()`, the path to a JDK tool should still be valid on the real OS. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2875899722
