On Tue, 3 Mar 2026 04:13:11 GMT, Alexey Semenyuk <[email protected]> wrote:

>> Makes sense. Do you know if we can introduce something like 
>> TKit.isRealWindows, ... or something to avoid confusion when to use what? I 
>> am ok keeping this way, but I think it might be confusing why usage is 
>> different for someone who does not now code well.
>
> There is `TKit.isMockingOperatingSystem()` which returns `true` if 
> `TKit.isWindows()`, `TKit.isLinux()`, and `TKit.isOSX()` return values that 
> are not equal to the values returned by `OperatingSystem.isWindows()`, 
> `OperatingSystem.isLinux()`, and `OperatingSystem.isMacOS()` respectively.

OS mocking is feasible mostly for testing error conditions. There are no plans 
to go beyond and test, say MSI packaging on any OS other than Windows. Given 
that I expect a limited amount of these oddities in the code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29908#discussion_r2876003175

Reply via email to