On Wed, 11 Mar 2026 16:14:38 GMT, Christian Stein <[email protected]> wrote:

> Please review this change to use JUnit Jupiter API in `jdk/com/sun` tests.

The JNDI changes look reasonable.

test/jdk/com/sun/crypto/provider/KeyFactory/PBEKeyDestroyTest.java line 55:

> 53:         assertFalse(key2.isDestroyed());
> 54:         assertTrue(key1.equals(key2));
> 55:         assertTrue(key2.equals(key1));

I guess you could use that opportunity to use `assertEquals` / 
`assertNotEquals` - here and below?

-------------

PR Review: https://git.openjdk.org/jdk/pull/30203#pullrequestreview-3931226994
PR Review Comment: https://git.openjdk.org/jdk/pull/30203#discussion_r2919826117

Reply via email to