On Wed, 11 Mar 2026 22:54:03 GMT, David Beaumont <[email protected]> wrote:
>> test/jdk/com/sun/crypto/provider/KeyFactory/PBEKeyDestroyTest.java line 55: >> >>> 53: assertFalse(key2.isDestroyed()); >>> 54: assertTrue(key1.equals(key2)); >>> 55: assertTrue(key2.equals(key1)); >> >> I guess you could use that opportunity to use `assertEquals` / >> `assertNotEquals` - here and below? > > Yes, please do. Better error messages. > > If you're in IntelliJ there's a "Simplifiable assertion" analysis you can > run, followed by "Misaligned assertEquals() parameters" that fixes all of > these things up in a couple of seconds. Addressed in https://github.com/openjdk/jdk/pull/30203/commits/4d57bd98f1cc62ed265ecb5205c9ab119c50dd71 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30203#discussion_r2925419267
