On Wed, 11 Mar 2026 17:19:58 GMT, Daniel Fuchs <[email protected]> wrote:
>> Please review this change to use JUnit Jupiter API in `jdk/com/sun` tests. > > test/jdk/com/sun/crypto/provider/KeyFactory/PBEKeyDestroyTest.java line 55: > >> 53: assertFalse(key2.isDestroyed()); >> 54: assertTrue(key1.equals(key2)); >> 55: assertTrue(key2.equals(key1)); > > I guess you could use that opportunity to use `assertEquals` / > `assertNotEquals` - here and below? Yes, please do. Better error messages. If you're in IntelliJ there's a "Simplifiable assertion" analysis you can run, followed by "Misaligned assertEquals() parameters" that fixes all of these things up in a couple of seconds. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30203#discussion_r2921401656
