On Thu, 21 May 2026 10:25:26 GMT, Viktor Klang <[email protected]> wrote:
>> Brent Christian has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains nine additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into smartcardio
>> - update copyright year
>> - Merge branch 'master' into smartcardio
>> - update example code in javax.smartcardio package doc to use try-finally
>> - minor comment update
>> - add missed clean() calls, update comments
>> - fix imports and copyright years
>> - add test case
>> - convert CardImpl finalizer to use Cleaner
>
> src/java.smartcardio/share/classes/sun/security/smartcardio/CardImpl.java
> line 62:
>
>> 60:
>> 61: /* State and code for cleanup */
>> 62: static class Context implements Runnable {
>
> Is there a reason for not being final?
>
> Suggestion:
>
> static final class Context implements Runnable {
It slipped my mind. :)
Fixed, thanks.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30683#discussion_r3284847042
