On Mon, 8 Jun 2026 17:52:35 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - adjust the implNote
>> - replace unset with "not set"
>> - minor code comment updates
>> - merge latest from master branch
>> - 8385924: GZIPInputStream.read() behaves differently on some Java versions
>
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 68:
>
>> 66: * to {@code true}, then the call to {@code InputStream.available()} is
>> skipped and a read
>> 67: * is performed on the underlying stream for a subsequent member. By
>> default,
>> 68: * the {@code jdk.util.gzip.tryReadAheadAfterTrailer} system property is
>> unset, and
>
> The JDK has 61 matches for "system property is not set" and zero for "system
> property is unset".
>
> "Unset" can be an adjective, but also a verb indicating some action has been
> taken, so I'd say "not set" is less ambiguous here.
>
> Suggestion:
>
> * the {@code jdk.util.gzip.tryReadAheadAfterTrailer} system property is not
> set, and
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31396#discussion_r3380006319
