On Tue, 9 Jun 2026 15:48:13 GMT, Alan Bateman <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - adjust the implNote
>> - replace unset with "not set"
>> - minor code comment updates
>> - merge latest from master branch
>> - 8385924: GZIPInputStream.read() behaves differently on some Java versions
>
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 71:
>
>> 69: * property in environments that process streams with a series of
>> members. By default,
>> 70: * the {@code jdk.util.gzip.tryReadAheadAfterTrailer} system property is
>> not set,
>> 71: * and {@code InputStream.available()} gets called.
>
> This is quite good, just a bit uncomfortable with the "may not always be
> accurate". What would you think of this:
>
> "GZIPInputStream depends on a high quality implementation of available() to
> reliably read a stream with a series of members. Consequently it may be
> necessary to set this property in environments that process streams with a
> series of members."
I spoke to Alan and we decided to make slight adjustment to the text Alan
proposed in the above comment. I have updated both the PR with the proposed
change and also updated the CSR with the latest state of this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31396#discussion_r3382183357
