On Mon, 8 Jun 2026 17:54:06 GMT, Volker Simonis <[email protected]> wrote:
>> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 69:
>>
>>> 67: * is performed on the underlying stream for a subsequent member. By
>>> default,
>>> 68: * the {@code jdk.util.gzip.tryReadAheadAfterTrailer} system property
>>> is unset, and
>>> 69: * {@code InputStream.available()} gets called.
>>
>> The implNote will likely move to the 2-arg constructor when a new
>> constructor is proposed.
>>
>> I think your wording is quite good. A suggestion is to replace
>>
>> "and a read is performed on the underlying stream for a subsequent member."
>>
>> with
>>
>> "and the implementation instead attempts to read a subsequent member in the
>> stream. It may be necessary to set this property in environments that
>> process streams with a series of members."
>>
>> When the new constructor arrives then it will be possible to update the
>> guidance.
>
> I can live with this proposal, although I'd still prefer to make the actual
> issue a little bit more explicit, e.g.:
>
> "and the implementation instead attempts to read a subsequent member in the
> stream. It may be necessary to set this property in environments that need to
> reliably process streams with a series of members, independently on the
> underlying input stream's implementation of `available()`."
Hello Alan, Volker, I've updated the PR to use a variant of these suggested
texts.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31396#discussion_r3379999899
