On Mon, 8 Jun 2026 15:19:18 GMT, Volker Simonis <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - adjust the implNote
>> - replace unset with "not set"
>> - minor code comment updates
>> - merge latest from master branch
>> - 8385924: GZIPInputStream.read() behaves differently on some Java versions
>
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 351:
>
>> 349: // be present
>> 350: if (!readNextMember) {
>> 351: return true; // no more members exist
>
> I think this comment is misleading. It should either read `// no more members
> exist or alwaysReadNextMember was false and available() returned 0` (but that
> just repeating the previous expression) or be removed.
I adjusted that comment in the latest update of the PR.
> src/java.base/share/classes/java/util/zip/GZIPInputStream.java line 367:
>
>> 365: if (numRemainingInInflater > m) {
>> 366: // position the inflater's input buffer to the start of
>> next member's deflated
>> 367: // data
>
> You already have longer lines in this file (e.g. line 362 above) so no need
> to put data on a new line.
Fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/31396#discussion_r3380003729
PR Review Comment: https://git.openjdk.org/jdk/pull/31396#discussion_r3380004528
