On Fri, 19 Jun 2026 19:27:00 GMT, ExE Boss <[email protected]> wrote: >> Jatin Bhateja has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains two additional >> commits since the last revision: >> >> - Merge branch 'master' of http://github.com/openjdk/jdk into JDK-8386255 >> - 8386255: Float16Vector NaN canonicalization for hashCode computation > > src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16Vector.java > line 3742: > >> 3740: // including signaling ones, contribute the same hash code. >> 3741: for (int i = 0; i < a.length; i++) { >> 3742: a[i] = >> Float16.float16ToShortBits(Float16.shortBitsToFloat16(a[i])); > > It might be better to check whether the bitpattern is a `NaN` instead of > going through the `Float16` allocation (which relies on inlining and escape > analysis to be eliminated, at least until **Valhalla** arrives and `Float16` > becomes a real value class)
Addressed! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/31587#discussion_r3449895186
