On Tue, 23 Jun 2026 18:28:57 GMT, ExE Boss <[email protected]> wrote:

>> Jatin Bhateja has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review comments resolution
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/X-Vector.java.template
>  line 5739:
> 
>> 5737:     String toString() {
>> 5738:         // now that toArray is strongly typed, we can define this
>> 5739:         return Arrays.toString(toArray());
> 
> `toFloat16Array()` can also be used in `toString()`:
> Suggestion:
> 
> #if[FP16]
>         // use Float16.toString instead of the raw short values
>         return Arrays.toString(toFloat16Array());
> #else[FP16]
>         // now that toArray is strongly typed, we can define this
>         return Arrays.toString(toArray());
> #end[FP16]
> 
> (might need a different issue, or increase the scope of this one)

Yes, it's already a different issue (see bug which links to it)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31587#discussion_r3462991567

Reply via email to